Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better consistency naming of headmodes #653

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

val-ba
Copy link
Contributor

@val-ba val-ba commented Jan 15, 2025

Summary

Fixes #652

Proposed changes

See #652

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@val-ba val-ba self-assigned this Jan 15, 2025
@val-ba val-ba requested review from Flova and ayin21 January 20, 2025 09:57
@val-ba val-ba marked this pull request as ready for review January 20, 2025 10:06
@val-ba
Copy link
Contributor Author

val-ba commented Jan 20, 2025

tested in sim and everything still worked

@val-ba val-ba requested a review from texhnolyze January 20, 2025 10:07
@val-ba
Copy link
Contributor Author

val-ba commented Jan 20, 2025

tested this on the real robot and works

@val-ba val-ba requested review from jaagut and confusedlama January 20, 2025 11:53
ayin21
ayin21 previously requested changes Jan 20, 2025
Copy link
Contributor

@ayin21 ayin21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix code style before merging

@Flova Flova merged commit a851e49 into main Jan 20, 2025
2 checks passed
@Flova Flova deleted the feature/better_consistency_naming_of_headmodes branch January 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Better consistency in naming of HeadMode/HeadMover search patterns
4 participants